added localize parameters to url #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
OlegPhenomenon
force-pushed
the
possibility-to-directly-change-localize
branch
from
ea2f397 to
faeba6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
In the current functionality of the auction, there's no direct link to the localized part of the service. To change localization, a link with a PATCH action is used, which either assigns the user's localization value in the database or sets it in the cookies. However, due to the need for marketing purposes to have a direct link to localization, a solution needs to be found.
How did you solve it?
It's very simple, I added a callback in the controller that tracks the "localize" parameter in the URL. Based on this parameter, the user's localization is set in their cookies. The direct link to localization looks like this:
https://auction.test/?localize=en
How do we verify that you didn't break anything?
You need to make sure that this functionality does not break the main localization features. The auction should still open for users with the localization that they have set. Websockets should also come with the correct localization.
Is there anything else we should know?
Yes, this feature does not work with browsers in incognito mode, as there are no cookies there.